From 14eb420fb684bc0d6eb97eec8d7afe564e31d0d7 Mon Sep 17 00:00:00 2001
From: Christian Darsow-Fromm <christian.darsow@physik.uni-hamburg.de>
Date: Wed, 6 Mar 2019 11:22:14 +0100
Subject: [PATCH] dockerfile improvements

---
 AUTHORS.rst     |  1 +
 Dockerfile      | 18 +++++-------------
 Dockerfile_lib  | 15 +++++++++++++++
 build_docker.sh |  7 +++----
 4 files changed, 24 insertions(+), 17 deletions(-)
 create mode 100644 Dockerfile_lib

diff --git a/AUTHORS.rst b/AUTHORS.rst
index 00c2f7d..26b6774 100644
--- a/AUTHORS.rst
+++ b/AUTHORS.rst
@@ -4,3 +4,4 @@ Contributors
 
 * Christian Darsow-Fromm <christian.darsow@physik.uni-hamburg.de>
 * Sebastian Steinlechner <sebastian.steinlechner@physnet.uni-hamburg.de>
+* Luis Dekant <ldekant@physnet.uni-hamburg.de>
diff --git a/Dockerfile b/Dockerfile
index 3ddb4e7..abe027c 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -1,24 +1,16 @@
-FROM python:3
+FROM lasnq/nqontrol:lib
 ENV PYTHONUNBUFFERED 1
 ENV BUILD_PACKAGES pandoc sass rsync openssh-client build-essential python3-tk
 
-RUN mkdir /code
 WORKDIR /code
 
 RUN apt-get update -y && apt-get install -y $BUILD_PACKAGES
 
-COPY ./env/adwin-lib*.tar.gz /code/
-
-RUN tar -xvf adwin-lib*.tar.gz
-WORKDIR /code/adwin-lib/
-RUN ./configure
-RUN make
-RUN make install
-
-WORKDIR /code
-
+# Install Python packages
 RUN pip install --upgrade pip
 ADD requirements.txt Makefile /code/
 RUN make requirements
 
-RUN /opt/adwin/sbin/adconfig add 1 TYPE net IP 192.168.0.3
+# Configure ADwin device
+ENV adwin_ip_address 192.168.0.3
+RUN /opt/adwin/sbin/adconfig add 1 TYPE net IP $adwin_ip_address
diff --git a/Dockerfile_lib b/Dockerfile_lib
new file mode 100644
index 0000000..21f1b43
--- /dev/null
+++ b/Dockerfile_lib
@@ -0,0 +1,15 @@
+FROM python:3
+
+ENV adwin_version 5.0.12
+
+WORKDIR /code
+
+# Install ADwin library
+RUN wget https://www.adwin.de/pub/cd/adwin-lib-$adwin_version.tar.gz
+RUN tar -xvf adwin-lib-$adwin_version.tar.gz
+WORKDIR /code/adwin-lib-$adwin_version/
+RUN ./configure
+RUN make
+RUN make install
+
+WORKDIR /code
diff --git a/build_docker.sh b/build_docker.sh
index 7d6d874..5f15d21 100755
--- a/build_docker.sh
+++ b/build_docker.sh
@@ -1,14 +1,13 @@
 #!/usr/bin/env bash
 set -e
 
-project=nqontrol
+project=nqontrol:lib
 
-docker build -t $project .
+docker build -t $project -f Dockerfile_lib .
 docker tag $project lasnq/$project
 docker push lasnq/$project
 
-cd env
-project=nqontrol:lib
+project=nqontrol
 
 docker build -t $project .
 docker tag $project lasnq/$project
-- 
GitLab