Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/AGSeifert/RFSurrogates.git. Pull mirroring updated .
  1. Sep 25, 2023
  2. Aug 04, 2023
  3. Aug 01, 2023
  4. Jul 28, 2023
  5. Jul 25, 2023
  6. Jul 24, 2023
    • Gärber, Florian's avatar
      chore: Release 0.3.3 · fbab4790
      Gärber, Florian authored
      fbab4790
    • Gärber, Florian's avatar
      fix: Set mean adjusted agreement with same variable to NA · 888b3eb6
      Gärber, Florian authored
      #4 Fixed the issue of writing past the end of the vector, however neglected use-cases where `candidates` was not equal to `variables`.
      This patch removes setting NA in `mean.index()` entirely, and applies the colname/rowname-wise fix to the created matrix instead.
      This fixes the issue where in the README example, the MAA of X7 with X2 would be set to NA, instead of with X7.
      This should also keep things stable against shuffled columns, or supplying variables in a different order than candidates, and should not encounter the issue of extra NAs.
      888b3eb6
    • Gärber, Florian's avatar
    • Gärber, Florian's avatar
      chore: Release 0.3.2 · 12a38a2b
      Gärber, Florian authored
      12a38a2b
    • Gärber, Florian's avatar
      fix: var.relations $surr.res returning matrix interspersed with unexpected NA (#4) · 9c66e3c1
      Gärber, Florian authored
      This PR fixes an issue where the result of `var.relations` would contain
      long runs of NA starting in the latter half of variables. This issue
      caused mean adjusted agreements to be shifted horizontally and across
      following rows.
      
      The issue was caused by setting the mean adjusted agreement of a
      variable with itself to NA incorrectly. Instead of using the current
      index, the variable index was used. This resulted in cells being
      incorrectly overwritten as NA if the variable index was smaller than the
      number of all variables, and in the implicit addition of NA beyond the
      end of the vector until the variable index when the variable index was
      larger than the number of all variables.
      
      This caused `mean.index` to return vectors with a length not exactly
      equal to the number of variables, which in the following steps caused an
      overrun when the concatenated vectors were being cast to a matrix with
      dimensions being exactly the length of all variables by all candidate
      variables. A warning message would appear when this occurred: `data
      length [...] is not a sub-multiple or multiple of the number of rows
      [...]`. It did not however notify that extra data was dropped
      implicitly.
      
      This PR also contains some basic test cases for the internal
      `mean.index` to prevent regression of this issue.
      - Assert that the length of the return value is always exactly as long
      as the number of variables
      - Assert that for unknown variables (that is, variables not represented
      in `list.res` or `index.variables`) the function will return an NA
      vector of the appropriate length.
      9c66e3c1
    • Gärber, Florian's avatar
      chore: Update NEWS · 17fd97b9
      Gärber, Florian authored
      17fd97b9
Loading