Skip to content
Snippets Groups Projects

New env dp3v5

Upgrade DP3 to new major version, use new environment.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Just to be sure: You are not waiting for to approval from me?

    I notice that diff lines got reduced … that's good. I moved env/2020Q3-cuda-gcc-openmpi out of /sw/TEST in the meantime.

    One question I do have: There is a number of entries in our example config now on 'latest' version. Isn't there a proper fixed version we could put there?

    (And … I do wonder if we actually could add a CI pipeline, since gitlab here so warmly recommends it. I guess we'd have to prepare a container from the LGC install including our software environment … or something vanilla using just ubuntu and pip for a second opinion. Well, it's more work:-/)

  • Hi Thomas, yes, I believe I need you approval since the master branch is protected.

    One question I do have: There is a number of entries in our example config now on 'latest' version. Isn't there a proper fixed version we could put there?

    For DP3 and WSClean, we need the current master, some impactful changes were introduces but are not yet released. Once they are released, I can update it to show a proper version tag.

    (And … I do wonder if we actually could add a CI pipeline, since gitlab here so warmly recommends it. I guess we'd have to prepare a container from the LGC install including our software environment … or something vanilla using just ubuntu and pip for a second opinion. Well, it's more work:-/)'

    I have no experience on this, this is a pipeline that tests the build on a container we provide? Not sure if this is overkill, on the other hand it can't hurt to learn how to do those things properly :smile: .

  • Ah, right. The master branch is protected. Only maintainers can change it.

    Francesco: I changed your role to maintainer now, as it doesn't make sense that I am a bottleneck here. Would you care to review and merge?

  • Gasperin, Dr. Francesco approved this merge request

    approved this merge request

  • mentioned in commit 8df57bc4

Please register or sign in to reply
Loading